Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UnWrap procedures from concrete WrapperFactories #3

Closed
victorsndvg opened this issue Oct 22, 2015 · 0 comments
Closed

Remove UnWrap procedures from concrete WrapperFactories #3

victorsndvg opened this issue Oct 22, 2015 · 0 comments
Labels
enhancement

Comments

@victorsndvg
Copy link
Owner

An unnecesary search into the WrapperFactoryList can be avoided implementing the Get method to return an unlimited polymorphic variable. With the following changes we will get a better performance:

  • The Get procedure will be implemented (as deferred) into DimensionsWrapper_xD.
  • ParameterListEntryContainer will use DimensionsWrapper_xD and select the appropiate DimensionsWrapper depending on the dimensions of the value.
  • Wrapper must return an unlimited polymorphic value
victorsndvg pushed a commit that referenced this issue Oct 22, 2015
@femparadmin
Cleaning some dirty things in the Wrapper hierarchy. Now xD Wrappers
eb9535b 
contains deferred Setters and Getters.

Now, Getters in ParameterListContainer doesn't have any dependecies
with WrapperFactoryList and we the values directly from the Wrappers.
This strategy removes at least one innecesary level of indirection.

Related with issue #3. Solved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@victorsndvg