Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support to disable dashjs default browser logging #383

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added support to disable dashjs default browser logging #383

wants to merge 3 commits into from

Conversation

Sharique-Hasan
Copy link

No description provided.

@Eloar
Copy link

Eloar commented Sep 6, 2016

Hey, how about making it fully configurable, not only Disable? It could be vgDashLog with true for enable and false for disable. Same as vgAutoPlay.

@kfeinUI
Copy link
Contributor

kfeinUI commented Apr 24, 2017

  • vg-dash should be responsible for managing its own configuration.
  • Perhaps a more flexible solution would be to add a callback to return the MediaPlayer instance? From there, you can operate on it as desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sharique-Hasan @Eloar @kfeinUI