Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a different name for player in the test page #245

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Use a different name for player in the test page #245

merged 1 commit into from
Oct 9, 2018

Conversation

mister-ben
Copy link
Contributor

Setting window.player in index.html can mask some problems while testing in the browser, such as using player in a component instead of this.player_.

This uses examplePlayer instead.

@brandonocasey brandonocasey merged commit c117984 into videojs:master Oct 9, 2018
@mister-ben mister-ben deleted the rename-player branch October 9, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mister-ben @brandonocasey