[Bugfix] m3u8 playlist is not updating when only endList changes #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porting the pull request to new http-streaming: videojs/videojs-contrib-hls#1425
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
romgen
changed the title
forbesjo
approved these changes
Feb 7, 2019
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting the pull request to new http-streaming after the old repo was archieved:
videojs/videojs-contrib-hls#1425
It's a one-line-fix.
Description
See #345
Possibly related issues:
videojs/videojs-contrib-hls#442
videojs/videojs-contrib-hls#550
videojs/videojs-contrib-hls#555
videojs/videojs-contrib-hls#111
Specific Changes proposed
This updates the logic for deciding whether a playlist has changed to check the endList property as well.
Requirements Checklist