Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Add fix for playlist not updating when only endList changes #1425

Closed
wants to merge 2 commits into from

Conversation

hpate-omicron
Copy link

@hpate-omicron hpate-omicron commented May 17, 2018

Description

See videojs/videojs-contrib-hls#1424

Possibly related issues:
#442
#550
#555
#111

Specific Changes proposed

This updates the logic for deciding whether a playlist has changed to check the endList property as well.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link
Contributor

@gesinger gesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note that we can update the comment above the code.

// consider the playlist unchanged if the number of segments is equal and the media
// sequence number is unchanged

But otherwise looks good to me, and thank you for the PR!

@hpate-omicron
Copy link
Author

hpate-omicron commented May 17, 2018

Oops, missed that, I've updated the comment and rebased :)

@forbesjo
Copy link
Contributor

Thank you for your PR but we will not be accepting new changes for this repo and will be archived very soon. I would advise you to open your PR against the next iteration of this project at https://github.com/videojs/http-streaming.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants