fix: mp4 sources that use bigint numbers #1217
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1217 +/- ##
==========================================
- Coverage 86.43% 86.31% -0.13%
==========================================
Files 39 39
Lines 9754 9796 +42
Branches 2268 2278 +10
==========================================
+ Hits 8431 8455 +24
- Misses 1323 1341 +18
Continue to review full report at Codecov.
|
| } | ||
| }); | ||
|
|
||
| return maxDuration; |
There was a problem hiding this comment.
Do we want to check to see if it's a bigint here or smaller than the MAX_SAFE_INTEGER to convert back? I expect most segments shouldn't have such a long duration.
src/segment-loader.js
Outdated
| const {start, end} = typeTimingInfo; | ||
| let duration; | ||
|
|
||
| // eslint-disable-next-line |
There was a problem hiding this comment.
is this because our version of eslint doesn't know that typeof can return bigint?
There was a problem hiding this comment.
Do you know if later eslint versions support it? If so, we should make a task for us to update eslint so that we can remove this comment (I see it below as well)
There was a problem hiding this comment.
I updated videojs-standard to support it, I think I can update it as a part of this pull request and remove this line.
Co-authored-by: Garrett Singer <[email protected]>
Description