Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: demo page representation selector #1416

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

adrums86
Copy link
Contributor

Description

The VHS demo page representation selector was not allowing the user to select the first or 0 indexed representation in the list.

Specific Changes proposed

Remove the !selectedIndex check and change the expected index to < 0 for "no element selected". See: https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedIndex

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@adrums86 adrums86 self-assigned this Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1416 (5043a24) into main (de183c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1416   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files          41       41           
  Lines       10145    10145           
  Branches     2351     2351           
=======================================
  Hits         8680     8680           
  Misses       1465     1465           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrums86 adrums86 merged commit 4ca3cab into main Aug 14, 2023
@adrums86 adrums86 deleted the fix-demoRepresentations branch August 14, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants