Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: native*Tracks options are no longer needed #889

Closed

Conversation

squarebracket
Copy link
Contributor

Description

I believe using native*Tracks: false is no longer needed since #76, but this crept back into the docs.

Specific Changes proposed

Remove native*Tracks: false from the overrideNative sections of the README.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Jul 6, 2020

It may be necessary depending on the browser you're using maybe? Like I think that it was necessary for Legacy Edge?
@mister-ben do you remember anything about it? I think you dealt with these options "recently".

@squarebracket
Copy link
Contributor Author

@gkatsev I think you're referring to this?

@squarebracket
Copy link
Contributor Author

It seems that the line was removed from the README, but not from the code snippet.

@gkatsev
Copy link
Member

gkatsev commented Jul 6, 2020

Yeah, that was probably it.

@gkatsev
Copy link
Member

gkatsev commented Aug 5, 2020

This comment seems to imply it's still needed? #920 (comment)

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated label Oct 4, 2020
@gkatsev
Copy link
Member

gkatsev commented Oct 5, 2020

Well, just noticed that Chrome 85 (85.0.4183.121) on macOS has audio tracks now which causes the native audio track to show up. The workaround right now is to enable nativeAudioTracks: false. So, I think this is still needed.

@stale stale bot removed the outdated label Oct 5, 2020
@stale
Copy link

stale bot commented Dec 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated label Dec 12, 2020
@stale stale bot closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants