fix: abort all loaders on earlyabort #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Oct 1, 2020
| @@ -12,7 +12,7 @@ export default { | |||
| BUFFER_LOW_WATER_LINE: 0, | |||
| MAX_BUFFER_LOW_WATER_LINE: 30, | |||
|
|
|||
| // TODO: Remove this when useBufferWaterLines is removed | |||
| // TODO: Remove this when experimentalBufferBasedABR is removed | |||
There was a problem hiding this comment.
so that we can remove this comments/code when we need to later on.
gkatsev
previously approved these changes
Oct 15, 2020
|
Is this something that we think is still necessary? Or could just be closed because we're not doing any earlyabort in the new ABR stuff? |
gesinger
reviewed
Nov 10, 2020
brandonocasey
force-pushed
the
fix/early-abort-all
branch
from
e9f0983 to
cca3c65
Compare
gesinger
approved these changes
Nov 10, 2020
evanfarina
pushed a commit
to evanfarina/http-streaming
that referenced
this pull request
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During low bandwidth situations continuing to download any segments over the video/audio segment is ill-advised as we need to get the buffer filled again ASAP. So when we get an early abort we have to abort all segment loaders to make way for the new playlist that is about to load, so that it can have priority.
Fixes #964