Feat/support bigint #135
Merged
Feat/support bigint #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
feat/support-bigint
branch
from
a7d21b2 to
2540a47
Compare
brandonocasey
force-pushed
the
feat/support-bigint
branch
2 times, most recently
from
a626eae to
68313ef
Compare
brandonocasey
force-pushed
the
feat/support-bigint
branch
from
3c52098 to
2072dea
Compare
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 92.84% 93.17% +0.32%
==========================================
Files 17 17
Lines 657 674 +17
Branches 214 224 +10
==========================================
+ Hits 610 628 +18
+ Misses 47 46 -1
Continue to review full report at Codecov.
|
gesinger
reviewed
Nov 1, 2021
gkatsev
reviewed
Nov 2, 2021
src/segment/urlType.js
Outdated
| @@ -34,13 +35,33 @@ export const urlTypeToSegment = ({ baseUrl = '', source = '', range = '', indexR | |||
| if (range || indexRange) { | |||
| const rangeStr = range ? range : indexRange; | |||
| const ranges = rangeStr.split('-'); | |||
| const startRange = parseInt(ranges[0], 10); | |||
| const endRange = parseInt(ranges[1], 10); | |||
| let startRange = parseInt(ranges[0], 10); | |||
There was a problem hiding this comment.
Unless I'm missing something, it seems like parseInt doesn't return a BigInt. We probably need to parse as BigInt and if it's under MAX_SAFE_INTEREGER convert it to a regular number.
Co-authored-by: Garrett Singer <[email protected]>
gesinger
approved these changes
Nov 3, 2021
gkatsev
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support 64 bit integer values for sidx