Preload and ns play #122

gkatsev · 2014-09-26T01:20:46Z

Make sure that the preload boolean gets set correctly based on the value specificed in html5 (unless preload=='none', set preload to true).
If we are preloading, we want to initialize the netconnection and netstream but not play. So, immediately after the ns is initialized and called play to add in the video url, we pause the ns.
We are are autoplaying, or play has been called, resume the ns.
Fire loadeddata after loadedmetadata in onmetadata
Only have onmetadata run once per video
Allow setting preload and autoplay programmatically.

Also, allow calling load without having the video play. Autoplay should autoplay the video as well.

tomjohnson916 · 2014-09-26T01:39:20Z

src/VideoJS.as

@@ -119,7 +119,7 @@ package{
                _app.model.autoplay = true;
            }

-            if(loaderInfo.parameters.preload != undefined && loaderInfo.parameters.preload == "true"){
+            if(loaderInfo.parameters.preload != "none"){


we may want this to be if(loaderInfo.parameters.preload && loaderInfo.parameters.preload != 'none')

If preload isn't present, we want it to be true. So, I think that check should be ok. But let me double check that we don't get an error.

Just checked it out and no error is thrown. If preload attribute isn't set on the video element, loaderInfo.parameters.preload is set to undefined, but no error is thrown and we preload the video.

tomjohnson916 · 2014-09-26T01:39:56Z

see comment above, otherwise LGTM.

Set preload to false if preload is set to 'none'

gkatsev · 2014-09-26T15:45:12Z

src/com/videojs/providers/HTTPVideoProvider.as

@@ -523,7 +528,9 @@ package com.videojs.providers{
                    break;

                case "NetStream.Buffer.Full":
-                    _model.broadcastEventExternally(ExternalEventName.ON_BUFFER_FULL);
+                    if(!_loadeddataFired){


This is to make sure that ON_BUFFER_FULL fired if for some reason it didn't fire in onMetaData.

gkatsev · 2014-09-26T16:25:45Z

Addresses videojs/video.js#1523

heff · 2014-09-26T16:52:54Z

Does the new ns pause cause any extra pause event?

Steve Heffernan (mobile)

On Sep 26, 2014, at 9:25 AM, Gary Katsevman [email protected] wrote:

Addresses videojs/video.js#1523

—
Reply to this email directly or view it on GitHub.

gkatsev · 2014-09-26T17:34:57Z

@heff good question. I'll double check.

gkatsev · 2014-09-26T21:48:52Z

@heff no, there is no extra pause event.

Don't bother firing ON_BUFFER_FULL in NetStream.Buffer.Full. Always fire it in onmetadata.

Unless pauseOnStart is set, we always want to resume the netstream.

gkatsev · 2014-09-27T20:10:11Z

Addresses #82.

dmlap · 2014-09-28T18:13:35Z

src/com/videojs/providers/HTTPVideoProvider.as

@@ -246,12 +248,13 @@ package com.videojs.providers{
        }

        public function init(pSrc:Object, pAutoplay:Boolean):void{
+            _onmetadadataFired = false;


on da meta da data da fired

dmlap · 2014-09-28T19:24:33Z

Did some comparison of events emitted by the video element (or the flash tech) during playback. You can check out the raw data if you're interested. I will follow up with some observations in a bit.

dmlap · 2014-09-28T19:57:37Z

Flash behavior on different platforms is relatively consistent. Comparing HTML playback with the SWF after this change, the notable discrepancies I see are:

progress consistently fired before loadstart
waiting not firing when preload is none
canplaythrough may fire before canplay
progress firing infrequently
loadstart occurs before play when autoplay is on
playing firing before loadedmetadata and loadeddata

dmlap · 2014-09-29T16:52:11Z

Even though there are still some discrepancies between Flash and HTML, I think this patch is a significant improvement. I'm going to file an issue for the observations above and pull this in.

Preload and ns play

When we attempted to ensure that "loadeddata" would never fire before "loadedmetadata" in videojs#122, we also stopped updated video dimensions from propagating to the video view. Retain the boolean to ensure that load events only occur once per video but scope the conditional so that the other effects of new metadata are still run.

gkatsev added 3 commits September 25, 2014 21:04

Make preload boolean reflect string value

27938ab

Call load on init if preload is not none

86cfc05

Also, allow calling load without having the video play. Autoplay should autoplay the video as well.

Add the swf

d3b4f0a

gkatsev mentioned this pull request Sep 26, 2014

Programmatically set source with Flash tech will automatically begin playing videojs/video.js#1523

Closed

tomjohnson916 reviewed Sep 26, 2014
View reviewed changes

gkatsev added 2 commits September 25, 2014 22:32

Fire loadeddata earlier

b80f6d9

Default preload to true.

46bfc89

Set preload to false if preload is set to 'none'

gkatsev reviewed Sep 26, 2014
View reviewed changes

gkatsev mentioned this pull request Sep 26, 2014

loadedmetadata event fires whenever currentTime is 0 #82

Closed

gkatsev added 4 commits September 26, 2014 18:23

Only fire run onmetadata once per video.

a0af7ae

Don't bother firing ON_BUFFER_FULL in NetStream.Buffer.Full. Always fire it in onmetadata.

Resume netstream if autoplay or play called.

5880608

Unless pauseOnStart is set, we always want to resume the netstream.

Allow setting autoplay. Get autoplay from model

ef187b6

Update the swf

df30cd5

dmlap reviewed Sep 28, 2014
View reviewed changes

dmlap added a commit that referenced this pull request Sep 29, 2014

Merge pull request #122 from videojs/preload-and-ns-play

f924c32

Preload and ns play

dmlap merged commit f924c32 into master Sep 29, 2014

dmlap deleted the preload-and-ns-play branch September 29, 2014 16:52

dmlap mentioned this pull request Sep 29, 2014

Exported events are not completely consistent with HTML #124

Closed

dmlap mentioned this pull request Jun 23, 2015

Small update to #164 #165

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preload and ns play #122

Preload and ns play #122

gkatsev commented Sep 26, 2014

tomjohnson916 Sep 26, 2014

gkatsev Sep 26, 2014

gkatsev Sep 26, 2014

tomjohnson916 commented Sep 26, 2014

gkatsev Sep 26, 2014

gkatsev commented Sep 26, 2014

heff commented Sep 26, 2014

gkatsev commented Sep 26, 2014

gkatsev commented Sep 26, 2014

gkatsev commented Sep 27, 2014

dmlap Sep 28, 2014

dmlap commented Sep 28, 2014

dmlap commented Sep 28, 2014

dmlap commented Sep 29, 2014

Preload and ns play #122

Preload and ns play #122

Conversation

gkatsev commented Sep 26, 2014

tomjohnson916 Sep 26, 2014

Choose a reason for hiding this comment

gkatsev Sep 26, 2014

Choose a reason for hiding this comment

gkatsev Sep 26, 2014

Choose a reason for hiding this comment

tomjohnson916 commented Sep 26, 2014

gkatsev Sep 26, 2014

Choose a reason for hiding this comment

gkatsev commented Sep 26, 2014

heff commented Sep 26, 2014

gkatsev commented Sep 26, 2014

gkatsev commented Sep 26, 2014

gkatsev commented Sep 27, 2014

dmlap Sep 28, 2014

Choose a reason for hiding this comment

dmlap commented Sep 28, 2014

dmlap commented Sep 28, 2014

dmlap commented Sep 29, 2014