Use pagehide instead of unload for PiP (#8321)

videojs · Jul 4, 2023 · 146008f · 146008f
1 parent b34cb2c
commit 146008f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/js/player.js b/src/js/player.js
@@ -3107,7 +3107,7 @@ class Player extends Component {
         this.player_.trigger('enterpictureinpicture');
 
         // Listen for the PiP closing event to move the video back.
-        pipWindow.addEventListener('unload', (event) => {
+        pipWindow.addEventListener('pagehide', (event) => {
           const pipVideo = event.target.querySelector('.video-js');
 
           pipContainer.replaceWith(pipVideo);
@@ -3142,7 +3142,7 @@ class Player extends Component {
    */
   exitPictureInPicture() {
     if (window.documentPictureInPicture && window.documentPictureInPicture.window) {
-      // With documentPictureInPicture, Player#leavepictureinpicture is fired in the unload handler
+      // With documentPictureInPicture, Player#leavepictureinpicture is fired in the pagehide handler
       window.documentPictureInPicture.window.close();
       return Promise.resolve();
     }

diff --git a/test/unit/player.test.js b/test/unit/player.test.js
@@ -2925,7 +2925,7 @@ QUnit.test('docPiP moves player and triggers events', function(assert) {
     return fakePiPWindow.document.body.querySelector(sel);
   };
   fakePiPWindow.close = function() {
-    fakePiPWindow.dispatchEvent(new Event('unload'));
+    fakePiPWindow.dispatchEvent(new Event('pagehide'));
     delete window.documentPictureInPicture.window;
   };