Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): revert resolveJsonModule in tsconfig #8310

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

mister-ben
Copy link
Contributor

Description

Removes resolveJsonModule from tsconfig.json, added in #8277.
Although adding that resolves one tsc complaint (relating to importing the version from
package.json), for some reason with it present tsc will include src/js in the paths within
dist/types

Requirements Checklist

  • [xx] Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@mister-ben mister-ben changed the title fix: revert resolveJsonModule in tsconfig fix(types): revert resolveJsonModule in tsconfig Jun 4, 2023
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #8310 (94d7e28) into main (0c01161) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8310   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files         112      112           
  Lines        7495     7495           
  Branches     1808     1808           
=======================================
  Hits         6188     6188           
  Misses       1307     1307           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mister-ben mister-ben merged commit 8f32b9f into videojs:main Jun 5, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants