fix(jsdoc): Corrections to jsdoc #8277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8277 +/- ##
==========================================
+ Coverage 82.36% 82.41% +0.05%
==========================================
Files 112 112
Lines 7483 7483
Branches 1804 1804
==========================================
+ Hits 6163 6167 +4
+ Misses 1320 1316 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mister-ben
changed the title
mister-ben
commented
May 23, 2023
| @@ -2209,6 +2209,29 @@ QUnit.test('should not allow to register custom player when any player has been | |||
| videojs.registerComponent('Player', Player); | |||
| }); | |||
|
|
|||
| QUnit.test('setters getters passed to tech', function(assert) { | |||
There was a problem hiding this comment.
This test is unrelated to the changes but makes Codecov happy as it increases coverage...
misteroneill
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrects some jsodc in Player, especially
Requirements Checklist