Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vjs standard #2099

Closed
wants to merge 4 commits into from
Closed

Add vjs standard #2099

wants to merge 4 commits into from

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Apr 29, 2015

So far, this adds in videojs-standard. standard --format is currently broken because it doesn't support the ES6 module syntax.

I'll be working towards making the changes to pass standard.
Addresses #2034.

TODO

  • Remove jshint and others
  • Update code
  • ???
  • Profit

@gkatsev gkatsev mentioned this pull request May 11, 2015
3 tasks
@heff
Copy link
Member

heff commented Jul 9, 2015

@gkatsev how can we continue to make progress on this one?

@forbesjo
Copy link
Contributor

forbesjo commented Oct 1, 2015

Would it be possible to do the same thing with just an eslint config?

@gkatsev
Copy link
Member Author

gkatsev commented Oct 1, 2015

The idea is that you don't need to worry about copying the eslint config. You just npm install -D videojs-standard and then add it to your build.

@forbesjo
Copy link
Contributor

forbesjo commented Oct 1, 2015

I guess I mean making a sharable config.

@gkatsev
Copy link
Member Author

gkatsev commented Oct 1, 2015

That still means that you would need to configure your app to use eslint. With stanard, you just install it and run it. No configurtion, no anything else.

@gkatsev gkatsev closed this Jan 26, 2016
@gkatsev gkatsev deleted the add-vjs-standard branch January 26, 2016 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants