New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor player.play() #4713

Closed

kocoten1992 wants to merge 1 commit into videojs:master from kocoten1992:patch-9

Contributor

kocoten1992 commented Nov 2, 2017

Requirements Checklist

refactor player.play()


          refactor player.play()

8f92841

Member

gkatsev commented Nov 2, 2017

Thanks, we'd probably want to hold off on this since we're changing the play method slightly in #4665.

Contributor Author

kocoten1992 commented Nov 7, 2017

I'm closing this, will comeback with different PR when thing is done

kocoten1992 closed this

kocoten1992 deleted the patch-9 branch

November 7, 2017 21:18

Member

gkatsev commented Nov 7, 2017

Makes sense, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet