chore: update node/nvmrc and various dependencies #7221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the transitive dependencies that's we have ends up breaking IE11 when we updated. Therefore, we cannot just blindly update all the dependencies like I did in #7220 and tried previously. Instead, we should be very careful when we update things as IE11 tests may stop working. Not sure if there's an easy way to figure out which module is causing these issues but hopefully, we can move away from supporting IE11 soon anyway. |
|
Looks like the qunit update is breaking out tests on IE11 for some reason. |
brandonocasey
approved these changes
May 4, 2021
gkatsev
changed the title
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7216, #6933, #6924, #7179