Feature detect setTimeout in auto setup for SSR #7247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some server side rendering environments (e.g., `execjs` since
version 2.8.0 [1]) `setTimeout` is not available. Since
`autoSetupTimeout` runs when Video.js is imported and tries to
schedule `autoSetup`, this can lead to errors of the following form in
server side rendering:
TypeError: scheduler is not a function
`autoSetup` already bailed out if run outside of a browser environment
or if globally disabled. To prevent calling `setTimeout`, we already
perform the `Dom.isReal` check in `autoSetupTimeout`. Checking
`options.autoSetup` has to remain in `autoSetup` to preserve backwards
compatiblity with apps that set the option after Video.js has loaded
but before the next tick.
[1] rails/execjs#43
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
tf
added a commit
to tf/pageflow
that referenced
this pull request
May 25, 2021
videojs/video.js#7247 REDMINE-18771
misteroneill
approved these changes
Jun 2, 2021
|
Congrats on merging your first pull request! 🎉🎉🎉 |
UsmanMuhammad
pushed a commit
to UsmanMuhammad/pageflow
that referenced
this pull request
Aug 12, 2022
videojs/video.js#7247 REDMINE-18771
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
…ojs#7247) Some JavaScript environments don't implement setTimeout, which causes Video.js to fail on require. Instead, move our Dom.isReal() check earlier to before we call setTimeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some server side rendering environments (e.g.,
execjssinceversion 2.8.0 [1])
setTimeoutis not available. SinceautoSetupTimeoutruns when Video.js is imported and tries toschedule
autoSetup, this can lead to errors of the following form inserver side rendering:
autoSetupalready bailed out if run outside of a browser environmentor if globally disabled. To prevent calling
setTimeout, we alreadyperform the
Dom.isRealcheck inautoSetupTimeout. Checkingoptions.autoSetuphas to remain inautoSetupto preserve backwardscompatiblity with apps that set the option after Video.js has loaded
but before the next tick.
[1] rails/execjs#43
Requirements Checklist