feat: Remove extend() method #7950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
misteroneill
approved these changes
Oct 3, 2022
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
BREAKING CHANGE: This removes the videojs.extend() method, please use ES6 classes instead.
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
BREAKING CHANGE: This removes the videojs.extend() method, please use ES6 classes instead.
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
BREAKING CHANGE: This removes the videojs.extend() method, please use ES6 classes instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had initially intended on leaving
extend()in Video.js 8 and deprecating it. However, maintaining backwards-compatibility after removing Babel class transpiling proved troublesome, so after some discussion we decided to remove it.