fix(types): Add jsdoc plugin to handle ts-style imports #8225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mister-ben
changed the title
Codecov Report
@@ Coverage Diff @@
## main #8225 +/- ##
==========================================
+ Coverage 82.11% 82.23% +0.12%
==========================================
Files 112 112
Lines 7402 7430 +28
Branches 1785 1791 +6
==========================================
+ Hits 6078 6110 +32
+ Misses 1324 1320 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gkatsev
approved these changes
Apr 4, 2023
|
Hmm, it's outputting filenames like |
|
Moved all the type imports inline, has resolved the build errors and netlify output. |
misteroneill
approved these changes
Apr 5, 2023
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The typedef import syntax we had to introduce for tsc output isn't compatible with jsdoc itself, see e.g. jsdoc/jsdoc#1645 . This is breaking the
docs:apitask.Specific Changes proposed
Adds a jsdoc plugin to transform the import syntax to be understood by jsdoc.
Fixes a few other errors in jsdoc.
Requirements Checklist