Skip to content
This repository has been archived by the owner on Jan 29, 2019. It is now read-only.

Add text tracks for both video tracks and audio-only tracks #179

Closed
wants to merge 1 commit into from
Closed

Add text tracks for both video tracks and audio-only tracks #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/virtual-source-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,8 +670,6 @@ export default class VirtualSourceBuffer extends videojs.EventTarget {
sortedSegments.video.segments.unshift(sortedSegments.video.initSegment);
sortedSegments.video.bytes += sortedSegments.video.initSegment.byteLength;
this.concatAndAppendSegments_(sortedSegments.video, this.videoBuffer_);
// TODO: are video tracks the only ones with text tracks?
addTextTrackData(this, sortedSegments.captions, sortedSegments.metadata);
} else if (this.videoBuffer_ && (this.audioDisabled_ || !this.audioBuffer_)) {
// The transmuxer did not return any bytes of video, meaning it was all trimmed
// for gop alignment. Since we have a video buffer and audio is disabled, updateend
Expand All @@ -686,6 +684,9 @@ export default class VirtualSourceBuffer extends videojs.EventTarget {
this.concatAndAppendSegments_(sortedSegments.audio, this.audioBuffer_);
}

// Add text tracks for both video tracks and audio-only tracks
addTextTrackData(this, sortedSegments.captions, sortedSegments.metadata);

this.pendingBuffers_.length = 0;

if (triggerUpdateend) {
Expand Down