Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description in readme #84

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Conversation

bcdarius
Copy link
Contributor

Description

Update description in readme. It currently has description from videojs-errors plugin.

A plugin that displays user-friendly messages when Video.js encounters an error.

README.md Outdated
@@ -5,7 +5,7 @@

[![NPM](https://nodei.co/npm/videojs-contrib-quality-levels.png?downloads=true&downloadRank=true)](https://nodei.co/npm/videojs-contrib-quality-levels/)

A plugin that displays user-friendly messages when Video.js encounters an error.
A library that exposes a list of quality levels available for the source.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also a plugin. This is probably fine, but I don't think it describes this plugin quite right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about?

A plugin that provides a framework of working with source quality levels.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good.

@Miserlou
Copy link

Miserlou commented Aug 6, 2019

This should be merged.

@brandonocasey brandonocasey merged commit 433df96 into videojs:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants