feat: support any ci #37
Conversation
brandonocasey
force-pushed
the
feat/support-any-ci
branch
3 times, most recently
from
d761b1a to
3a7cd3d
Compare
brandonocasey
force-pushed
the
feat/support-any-ci
branch
from
3a7cd3d to
23ba3d5
Compare
| Object.keys(libPkg.dependencies).forEach(function(p) { | ||
| if ((/^karma-/).test(p)) { | ||
| karmaPlugins.push(require(p)); | ||
| Object.keys(libPkg.dependencies).forEach(function(pkgName) { |
There was a problem hiding this comment.
support scoped packages. noticed this when I tried to add edge/edgium support but there are only scoped packages. I think this fix should stay even though I backed out edge/edgium support.
brandonocasey
force-pushed
the
feat/support-any-ci
branch
from
891b3f3 to
835f01c
Compare
| base: 'ChromeHeadless', | ||
| flags: ['--no-sandbox'] | ||
| // detect if we are being run in "server mode" with --no-single-run | ||
| const inServerMode = () => { |
There was a problem hiding this comment.
Moved this to it's own function.
| // 1. if we are in ci and no browsers are passed in | ||
| // 2. We are in server mode and serverBrowsers is set | ||
| // 3. We are not in server mode and browsers is set | ||
| const normalizeBrowsers = ({serverMode, browsers, settings}) => { |
There was a problem hiding this comment.
Moved this to its own function.
| browserstackLaunchers, | ||
| teamcityLaunchers, | ||
| // default settings | ||
| const getDefaults = () => { |
There was a problem hiding this comment.
Moved defaults to their own function.
| @@ -126,18 +123,7 @@ module.exports = function(config) { | |||
| > Type: `Boolean` | |||
| > Default: `true` | |||
|
|
|||
| If we should prefer running headless browsers. This will change the defaults for `travisLaunchers` as well as automatic browser detection. Make sure to handle this in [`browsers`](###browsers) | |||
|
|
|||
| ### `detectBrowsers` | |||
There was a problem hiding this comment.
We only detect browsers when browsers are not explicitly defined. It seems rather pointless to skip detect browsers when no browsers are set as nothing will run, causing an error.
There was a problem hiding this comment.
Ah, makes sense. Probably worth documenting that.
Plus, since this change is already a breaking change there's no issue in removing an option. Though, should this be a breaking change? I guess it probably doesn't matter that much since the functionality is the same, and we're not looking to add other functionality that could be useful to travis/TC items directly yet.
There was a problem hiding this comment.
I think for docs maybe something like detect browsers automatically if no browsers were configured under the browsers option?
There was a problem hiding this comment.
yeah that makes sense I will add that under the browsers option. I think this pull request was going to be a breaking change anyway just to be safe.
Makes this project more generic since travis has had some major slow downs for open source and we are switching to github actions for ci.
BREAKING CHANGES
detectBrowsersoption which really didn't do anything anyway.--browsersin to karma.