Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linting rules to be correct #10

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Update linting rules to be correct #10

merged 1 commit into from
Feb 27, 2019

Conversation

stevenjack
Copy link
Contributor

Problem

New method to check what shouldn't be in a file had the wrong linting rules in it.

Solution

  • Add correct ones.

Notes

  • Remember to tag your merge commit after merging 👍
  • Remember to add the Clubhouse ticket url as a comment ♣️ 🏠

@stevenjack stevenjack requested a review from a team February 27, 2019 12:23
@stevenjack
Copy link
Contributor Author

stevenjack commented Feb 27, 2019 •
edited
Loading

https://app.clubhouse.io/vidsy/story/6762

thaffenden
thaffenden approved these changes Feb 27, 2019
View reviewed changes
Copy link

@thaffenden thaffenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@stevenjack stevenjack merged commit d1260ac into master Feb 27, 2019
@stevenjack stevenjack deleted the fix/correct-linting branch February 27, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaffenden thaffenden thaffenden approved these changes

Assignees
No one assigned
Labels
READY Task
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjack @thaffenden