Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

Ease usage with docker entrypoint and env vars #15

Merged
merged 9 commits into from
Apr 4, 2022
Merged

Ease usage with docker entrypoint and env vars #15

merged 9 commits into from
Apr 4, 2022

Conversation

barcus
Copy link

@barcus barcus commented Apr 3, 2022

Hello @vierbergenlars, thank you for this nice exporter :)
This MR to ease usage of the docker image using environment variables.
CMD can be overridden using dedicated command in docker run or docker-compose file.
I fact would like to add this exporter in my docker-compose file (https://github.com/barcus/bareos)

  • add entrypoint script to manage exporter args
  • freeeze golang and busybox images version
  • add WAIT_FOR_DB variable
  • use upx to compress exporter executable

@barcus barcus changed the title use entrypoint and env vars Ease usage with docker entrypoint and env vars Apr 3, 2022
Copy link
Owner

@vierbergenlars vierbergenlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your PR to make the docker image more usable.

I have one blocking remark: the backwards compatibility of the Docker image must be retained, as it is used in production.

My other documentation remarks are more suggestions on how to improve the docs.

@barcus barcus requested a review from vierbergenlars April 3, 2022 22:12
Copy link
Owner

@vierbergenlars vierbergenlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now!

@vierbergenlars vierbergenlars merged commit b3ad52e into vierbergenlars:master Apr 4, 2022
@barcus barcus deleted the dsn-using-var branch April 4, 2022 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants