Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint.yml For Better Security #175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RynoCODE
Copy link

This commit is for security. If there are any pull requests that are mistakenly merged this will block any malicious intent.

This commit is for security. If there are any pull requests that are mistakenly merged this will block any malicious intent.
@vikhyat
Copy link
Owner

vikhyat commented Jan 2, 2025

Any idea why it didn't run the workflow on this PR?

@RynoCODE
Copy link
Author

RynoCODE commented Jan 3, 2025

Because you have added

on:
  # Only run on PRs to avoid duplicate runs
  pull_request:
    paths:
      - 'clients/python/**'
      - '.github/workflows/python-client-tests.yml'

so the trigger conditions are clients/python/* and .github/workflows/python-client-tests.yml'

instead if you keep:

on:
    pull_request:

I have also added permissions to other workflows for better security:
#184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants