fix artefact generation bumping @embroider/* packages #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #67.
the root cause of the problem is that initializer file
dist/_app_/initializers/ember-engines-router-service.js
published to NPM has following contents:and it should be
As
dist
folder gets generated at build time and handled by rollup (technically by rollup plugins), bumping@embroider/addon-dev
package to the latest fixes this issue.@villander could you please release 4.0.1 once this and #72 gets merged? (just a reminder Release Process described in
RELEASE.md
)