Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vint errors #136

Merged
merged 8 commits into from
Aug 6, 2019
Merged

Fix vint errors #136

merged 8 commits into from
Aug 6, 2019

Conversation

tyru
Copy link
Member

@tyru tyru commented Aug 1, 2019

Fix #111

@tyru tyru force-pushed the run-vint-on-travis branch from 6662c36 to d94a282 Compare August 1, 2019 15:23
@tyru
Copy link
Member Author

tyru commented Aug 1, 2019

travis checks are not showed... wtf?
image
but build seems working.
https://travis-ci.org/vim-jp/vim-vimlparser/builds/566529436

@blueyed do you know something about this...? ;)

@tyru
Copy link
Member Author

tyru commented Aug 1, 2019

@blueyed and can you review this?

tyru
tyru commented Aug 1, 2019
View reviewed changes
autoload/vimlparser.vim Outdated
@@ -28,7 +28,7 @@ function! vimlparser#test(input, ...)
endtry
endfunction

function! s:numtoname(num)
function! s:numtoname(num) abort
let sig = printf("function('%s')", a:num)
for k in keys(s:)
if type(s:[k]) == type({})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why vint does not show error about this? 🤔

@tyru
Copy link
Member Author

tyru commented Aug 1, 2019

image
now I figured out organization grant was revoked... (why?)
granted permission and now travis appears, but codecov disappered!? 🤣
image

@tyru tyru force-pushed the run-vint-on-travis branch from 07ea28e to d94a282 Compare August 1, 2019 16:07
@tyru
== -> ==#
b0018dc 
vint didn't complain about these cases...
@tyru
Copy link
Member Author

tyru commented Aug 2, 2019

Fixed == to ==#. b0018dc
I don't know why vint did not show the errors about this though.

@tyru tyru requested a review from blueyed August 2, 2019 10:38
@tyru
Copy link
Member Author

tyru commented Aug 2, 2019

@blueyed review please 🙏

@tyru tyru force-pushed the run-vint-on-travis branch from 5873f0e to 40f21cb Compare August 2, 2019 11:25
@tyru tyru mentioned this pull request Aug 2, 2019
Open
@blueyed blueyed mentioned this pull request Aug 3, 2019
Merged
@blueyed
Copy link
Contributor

blueyed commented Aug 3, 2019

Trying a different approach in #139.

@blueyed
Copy link
Contributor

blueyed commented Aug 3, 2019

I think #139 is slightly better by using "checkvim".
It uses the master branch to fix installation issues - I should really find some time to fix vint / release 0.4..

@blueyed
Copy link
Contributor

blueyed commented Aug 3, 2019

We can pick your fixed into it - or the other way around.

@tyru tyru changed the title Run vint on travis Fix vint errors Aug 6, 2019
@tyru tyru merged commit 847601a into master Aug 6, 2019
@tyru tyru deleted the run-vint-on-travis branch August 6, 2019 23:07
@tyru tyru mentioned this pull request Aug 6, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed Awaiting requested review from blueyed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run vint on CI
2 participants
@tyru @blueyed