Create empty params by default for SplObjectStorage

Fixes #4055
vimeo · Aug 25, 2020 · 346d475 · 346d475
1 parent 2b060b7
commit 346d475
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/NewAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/NewAnalyzer.php
@@ -595,7 +595,11 @@ public static function analyze(
                                     $template_result->upper_bounds
                                 );
                             } else {
-                                $generic_param_type = array_values($base_type)[0][0];
+                                if ($fq_class_name === 'SplObjectStorage') {
+                                    $generic_param_type = Type::getEmpty();
+                                } else {
+                                    $generic_param_type = array_values($base_type)[0][0];
+                                }
                             }
 
                             $generic_param_type->had_template = true;

diff --git a/tests/MethodCallTest.php b/tests/MethodCallTest.php
@@ -910,6 +910,13 @@ final public function getValue() {
                         echo strlen($a->getValue());
                     }',
             ],
+            'newSplObjectStorageDefaultEmpty' => [
+                '<?php
+                    $a = new SplObjectStorage();',
+                [
+                    '$a' => 'SplObjectStorage<empty, empty>',
+                ]
+            ],
         ];
     }