Fix #1555 - allow phantom class constants

vimeo · Feb 19, 2020 · aea3382 · aea3382
1 parent 520b646
commit aea3382
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticCallAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticCallAnalyzer.php
@@ -145,7 +145,9 @@ public static function analyze(
                     }
                 }
 
-                if (!$does_class_exist) {
+                if (!isset($context->phantom_classes[strtolower($fq_class_name)])
+                    && !$does_class_exist
+                ) {
                     $does_class_exist = ClassLikeAnalyzer::checkFullyQualifiedClassLikeName(
                         $statements_analyzer,
                         $fq_class_name,

diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ClassConstFetchAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ClassConstFetchAnalyzer.php
@@ -74,7 +74,9 @@ public static function analyze(
                 );
 
                 if ($stmt->name instanceof PhpParser\Node\Identifier) {
-                    if (!$context->inside_class_exists || $stmt->name->name !== 'class') {
+                    if ((!$context->inside_class_exists || $stmt->name->name !== 'class')
+                        && !isset($context->phantom_classes[strtolower($fq_class_name)])
+                    ) {
                         if (ClassLikeAnalyzer::checkFullyQualifiedClassLikeName(
                             $statements_analyzer,
                             $fq_class_name,

diff --git a/tests/ClassTest.php b/tests/ClassTest.php
@@ -513,6 +513,18 @@ public function get(): A {
                         }
                     }',
             ],
+            'noErrorsAfterClassExists' => [
+                '<?php
+                    if (class_exists(A::class)) {
+                        if (method_exists(A::class, "method")) {
+                            echo A::method();
+                        }
+
+                        echo A::class;
+                        /** @psalm-suppress MixedArgument */
+                        echo A::SOME_CONST;
+                    }'
+            ],
         ];
     }