Enable extensions based on composer.json instead of those loaded at runtime (fixes #5482). #7107

AndrolGenhald · 2021-12-08T23:53:17Z

No description provided.

src/Psalm/Internal/Provider/ReturnTypeProvider/PdoStatementReturnTypeProvider.php

AndrolGenhald · 2021-12-08T23:57:29Z

stubs/extensions/pdo.phpstub

+    public const PARAM_LOB = 3;
+    public const PARAM_STMT = 4;
+    public const PARAM_BOOL = 5;
+    // public const PARAM_STR_NATL = 1073741824; since 7.2


I'm not sure how to make this only available in 7.2, I'd rather not make a whole new stub file, but it doesn't look like psalm supports @since? Not immediately necessary anyway.

Yeah, recurrent issue. It should not be an issue if we start generating stubs as we talked

AndrolGenhald · 2021-12-08T23:59:22Z

I figure there should probably be an XML config to enable/disable extensions as well, but this seems to work fine so far.

.github/workflows/ci.yml

AndrolGenhald · 2021-12-09T13:51:42Z

I was just thinking about require-dev. It would be nice if it were possible to load extensions in require-dev for specific namespaces such as tests, but as far as I'm aware there's no way to tell Psalm to only load a stub for use in a specific namespace. This might have to be part of a more general require-dev support, it would also be nice to exclude loading require-dev libraries when inspecting non-dev code.

AndrolGenhald · 2021-12-09T21:31:21Z

Tests all run fine locally with #7110 merged. I'll see to getting an XML config added and then I think it's good to go.

orklah · 2021-12-11T22:13:06Z

Seems like tests are failing. Maybe due to your last commit?

AndrolGenhald · 2021-12-11T22:37:26Z

Odd, they all run fine locally. Must be a PHP version issue.

Edit: Wait no, of course, it's because I re-enabled the SOAP extension locally after I got those tests to work the first time.

AndrolGenhald · 2021-12-11T22:51:11Z

I need to read before going and debugging again...
Those tests fail due to a separate bug fixed in #7110, when that's merged I'll rebase and everything should be fine.

AndrolGenhald · 2021-12-14T14:20:41Z

@orklah anything I can do to streamline review of some of these pull requests? I'm seeing several other pull requests that are going to cause conflicts.

weirdan · 2021-12-14T17:26:10Z

Ideally I'd like to merge CI fix and CS change before all other PRs.

orklah · 2021-12-14T19:16:43Z

@AndrolGenhald Thanks for your PRs, it's really great! I'm having a hard time reviewing everything though!

This one is relatively easy to review, but if you could take the habit of summarize your most complex PR to explain the reason behind the biggest changes and challenges you encountered, it would help a lot :)

AndrolGenhald · 2021-12-14T21:29:09Z

Feel free to liberally point out any areas that aren't explained well enough. In the future I'll try to do multiple commits when moving around and deduplicating code sections, I expect being able to see each step in the refactor would help a lot with reviewing.

AndrolGenhald · 2022-01-20T21:36:55Z

@orklah I believe this is ready to go, just blocked by #7110 (failing tests are due to the added stub not being handled correctly).

AndrolGenhald · 2022-01-22T20:26:12Z

Currently rebasing on master, I'll have to open a pull request against 4.x to add loadXdebugStub to the deprecated attributes list. Doesn't look like we're documenting those in UPGRADING.md?

orklah · 2022-01-22T20:37:31Z

No, we only documented config properties removal in UPGRADING

AndrolGenhald · 2022-01-22T21:35:05Z

@orklah I'm trying to update the baseline on 4.x, but every time I try it's just giving me an empty baseline and saying "No Errors" without actually performing a scan. Any idea what's going on there?

It looks like there are also some errors showing up on 4.x that aren't in the baseline, but it's being a bit inconsistent. Might be because I'm trying to modify it manually.

src/Psalm/Config.php

…untime (fixes vimeo#5482).

…literals.

AndrolGenhald · 2022-01-27T23:00:47Z

@orklah is there any plan to version the documentation on psalm.dev? Maybe add psalm.dev/docs/v4 and psalm.dev/docs/v5 or something? Not sure if I should be removing deprecated stuff from the documentation or not.

orklah · 2022-01-27T23:23:19Z

No plan for that no. Changes will be little enough I think and we'll probably advise anyone complaning to update versions anyway...

AndrolGenhald · 2022-01-27T23:49:44Z

Should I add back in the documentation for loadXdebugStub then with a deprecation/removed note? I worry about people upgrading from an older version of 4 straight to 5, so they might never get the deprecation notice and see what they're supposed to do to fix it.

orklah · 2022-01-28T17:45:49Z

Thanks!

AndrolGenhald · 2022-01-28T17:49:41Z

@orklah

Should I add back in the documentation for loadXdebugStub then with a deprecation/removed note? I worry about people upgrading from an older version of 4 straight to 5, so they might never get the deprecation notice and see what they're supposed to do to fix it.

orklah · 2022-01-28T17:54:15Z

You can add a note in UPGRADING I guess, I'd just like to avoid keeping things in the xml with no uses

AndrolGenhald · 2022-01-28T17:57:00Z

You can add a note in UPGRADING I guess, I'd just like to avoid keeping things in the xml with no uses

Oh, sorry I wasn't clear enough, I meant the documentation at psalm.dev/docs. If we're not versioning that people will be using Psalm 5 docs for Psalm 4, so we should probably be careful to avoid removing documentation.

orklah · 2022-01-28T18:27:06Z

I'm fine with that :)

weirdan · 2022-01-28T19:30:15Z

If we're not versioning that people will be using Psalm 5 docs for Psalm 4, so we should probably be careful to avoid removing documentation.

Should the need arise we'll provide documentation for previous versions on readthedocs.org, so feel free to remove outdated parts from master.

AndrolGenhald commented Dec 8, 2021

View reviewed changes

src/Psalm/Internal/Provider/ReturnTypeProvider/PdoStatementReturnTypeProvider.php Show resolved Hide resolved

AndrolGenhald commented Dec 8, 2021

View reviewed changes

AndrolGenhald force-pushed the feature/5482-load-extensions-based-on-composer-config branch from f5920be to 46a5e8c Compare December 9, 2021 00:03

AndrolGenhald commented Dec 9, 2021

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

AndrolGenhald mentioned this pull request Dec 9, 2021

Fix stub parent class not loaded. #7110

Merged

AndrolGenhald force-pushed the feature/5482-load-extensions-based-on-composer-config branch 3 times, most recently from 356192c to 401b664 Compare December 9, 2021 20:49

AndrolGenhald marked this pull request as ready for review December 9, 2021 23:02

AndrolGenhald mentioned this pull request Dec 14, 2021

fix CI #7153

Merged

AndrolGenhald mentioned this pull request Jan 13, 2022

Add Exception->getCode() return type provider #7390

Merged

orklah added the PR: Needs work label Jan 20, 2022

orklah added PR: blocked and removed PR: Needs work labels Jan 20, 2022

orklah added the release:feature The PR will be included in 'Features' section of the release notes label Jan 22, 2022

AndrolGenhald force-pushed the feature/5482-load-extensions-based-on-composer-config branch from 28a3efe to 63168ac Compare January 22, 2022 20:44

orklah reviewed Jan 27, 2022

View reviewed changes

src/Psalm/Config.php Outdated Show resolved Hide resolved

AndrolGenhald added 8 commits January 27, 2022 16:30

Enable extensions based on composer.json instead of those loaded at r…

2fe4fc3

…untime (fixes vimeo#5482).

Add SoapFault stub.

63cd3f3

Disable all PHP extensions for CI except those required by psalm.

4672e5a

Add SoapHeader stub.

02cd7bb

Add XML config options to enable/disable PHP extensions.

8132b57

Add documentation for enableExtensions and disableExtensions.

5cd3b68

Fix copy/paste fail and other psalm/cs issues, reduce duplication of …

c2b44ff

…literals.

Remove deprecated loadXdebugStub attribute.

5c01913

AndrolGenhald force-pushed the feature/5482-load-extensions-based-on-composer-config branch from 63168ac to 5c01913 Compare January 27, 2022 22:55

Add stub for PDOException.

653d17f

Add note about $load_xdebug_stub removal to UPGRADING.md.

d705d5e

orklah merged commit 2966f1c into vimeo:master Jan 28, 2022

orklah mentioned this pull request Feb 3, 2022

DOMNodeList::item() gives DOMElement instead of DOMNode #7567

Open

This was referenced Feb 3, 2022

Fix extension capitalization issue, add extensions to version message. #7574

Merged

PDOStatement::fetchObject(class-string) return type not recognized in 5.0a1 #7566

Closed

orklah mentioned this pull request Feb 4, 2022

phpredis stubs wrong again? #7581

Closed

orklah mentioned this pull request Feb 14, 2022

PDOException extends RuntimeException and can use int code errors #7673

Merged

This was referenced Feb 18, 2022

Add an option to warn about undeclared global functions regardless of Psalm's signature map. #1025

Open

query re: non-built-in extension functions #2620

Open

mhsdesign mentioned this pull request Oct 21, 2023

Bug? Callmap doesnt work for extensions if the extension is not installed #10307

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable extensions based on composer.json instead of those loaded at runtime (fixes #5482). #7107

Enable extensions based on composer.json instead of those loaded at runtime (fixes #5482). #7107

AndrolGenhald commented Dec 8, 2021

AndrolGenhald Dec 8, 2021

orklah Jan 27, 2022

AndrolGenhald commented Dec 8, 2021

AndrolGenhald commented Dec 9, 2021

AndrolGenhald commented Dec 9, 2021

orklah commented Dec 11, 2021

AndrolGenhald commented Dec 11, 2021 •

edited

Loading

AndrolGenhald commented Dec 11, 2021

AndrolGenhald commented Dec 14, 2021

weirdan commented Dec 14, 2021

orklah commented Dec 14, 2021

AndrolGenhald commented Dec 14, 2021

AndrolGenhald commented Jan 20, 2022 •

edited

Loading

AndrolGenhald commented Jan 22, 2022

orklah commented Jan 22, 2022

AndrolGenhald commented Jan 22, 2022 •

edited

Loading

AndrolGenhald commented Jan 27, 2022

orklah commented Jan 27, 2022

AndrolGenhald commented Jan 27, 2022

orklah commented Jan 28, 2022

AndrolGenhald commented Jan 28, 2022

orklah commented Jan 28, 2022

AndrolGenhald commented Jan 28, 2022

orklah commented Jan 28, 2022

weirdan commented Jan 28, 2022

Enable extensions based on composer.json instead of those loaded at runtime (fixes #5482). #7107

Enable extensions based on composer.json instead of those loaded at runtime (fixes #5482). #7107

Conversation

AndrolGenhald commented Dec 8, 2021

AndrolGenhald Dec 8, 2021

Choose a reason for hiding this comment

orklah Jan 27, 2022

Choose a reason for hiding this comment

AndrolGenhald commented Dec 8, 2021

AndrolGenhald commented Dec 9, 2021

AndrolGenhald commented Dec 9, 2021

orklah commented Dec 11, 2021

AndrolGenhald commented Dec 11, 2021 • edited Loading

AndrolGenhald commented Dec 11, 2021

AndrolGenhald commented Dec 14, 2021

weirdan commented Dec 14, 2021

orklah commented Dec 14, 2021

AndrolGenhald commented Dec 14, 2021

AndrolGenhald commented Jan 20, 2022 • edited Loading

AndrolGenhald commented Jan 22, 2022

orklah commented Jan 22, 2022

AndrolGenhald commented Jan 22, 2022 • edited Loading

AndrolGenhald commented Jan 27, 2022

orklah commented Jan 27, 2022

AndrolGenhald commented Jan 27, 2022

orklah commented Jan 28, 2022

AndrolGenhald commented Jan 28, 2022

orklah commented Jan 28, 2022

AndrolGenhald commented Jan 28, 2022

orklah commented Jan 28, 2022

weirdan commented Jan 28, 2022

AndrolGenhald commented Dec 11, 2021 •

edited

Loading

AndrolGenhald commented Jan 20, 2022 •

edited

Loading

AndrolGenhald commented Jan 22, 2022 •

edited

Loading