Analyze attribute statements instead of constructing virtual statements. #7692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrolGenhald
added
the
release:fix
AndrolGenhald
force-pushed
the
bugfix/7685-attribute-analysis
branch
from
af5f317 to
0476ca7
Compare
|
I never tried to check issue location like that. It seems fine to me, is it ready to merge on your side? |
|
Looks ready to me, I'll double check on psalm.dev after it's merged to make sure locations are correct. |
|
Thanks! |
Merged to master, should be available on psalm.dev shortly. |
This was referenced Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7685.
My main worry here is that the code locations might get messed up somehow. I added the line/column numbers to the existing tests, but is there a way to test the ending column of the message in addition to the starting column?