-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Move secrets to .env file #252
Comments
@irsol Thanks for reporting this. Let's do the improvements in smaller PRs. It helps in reviewing and ensuring everything still works. |
@vinitkumar tests still don't work. I can create a new branch or work in my forked repo and create new pull request from there. Which way would you prefer? |
Can you access the associated travis env to see what is missing? I think
it is because of env variables you moved but they are not declared in the
travis.
…On Tue, Nov 19, 2019, 00:24 Iryna Soltyska ***@***.***> wrote:
@vinitkumar <https://github.com/vinitkumar> tests still don't work. I can
create a new branch or work in my forked repo and create new pull request
from there. Which way would you prefer?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#252?email_source=notifications&email_token=AAEDITXTDKFCGGJLBJ5DFGDQULQHZA5CNFSM4JJJNUT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELQQNQ#issuecomment-555157558>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEDITWXC5L3WRM6R6VA43LQULQHZANCNFSM4JJJNUTQ>
.
|
@vinitkumar I added all needed env variables to Travis and opened new pull request which will fix all issues with tests. #263 |
@vinitkumar all tests passed in my branch https://travis-ci.org/irsol/node-twitter/builds/617127398 |
@irsol thanks for the effort. However, looks like you added the env variable in your own fork and not this main upstream travis. Could you please update the env variables and their values here? I will update them to to the project and restart the build. Or you can try setting them directly here (https://travis-ci.org/vinitkumar/node-twitter?utm_medium=notification). Let me know if you are able to do this? |
the variables are already there. But I still can not build develop branch. |
Anyways, I will merge your PR and fix the issues with CI later. |
I will also look at the issue. |
All tests passed after the merge. |
Describe the solution you'd like
Add secrets to a
.env
file in the project root folder and add.env
to.gitignore
file, so it will never be committed. It helps to avoid stealing github and other secrets.The text was updated successfully, but these errors were encountered: