-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/express 4 migration #181
Conversation
@vinitkumar I'll let you merge this into master. |
@Engineering-Robert Mostly looks great! One question though, did we needed to move server.js into app? I intentionally kept it outside as it has little to do with app code. |
|
||
app.use((req, res) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to remove the render of 404 page on not found routes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, the 404 page was always being rendered when it was included in express.js, so I had to move it to the bottom of routes.js. I think it has to do with not using app.router (deprecated) anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay!
A lot of projects i've been looking at have their main server file in a "src" folder so I wanted to follow along with that practice by adding our server.js into the app folder. This way our root directory only contains dot files, READMEs, and other config stuff. Thoughts? |
…ode-twitter into feature/express-4-migration
Issue
Fixes #140
Type
Description
Now using Express 4.x instead of version 3.
Screenshots (if appropriate):
How Has This Been Tested?
This change is