Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background.js Refactor #16

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JordanRosas
Copy link

Refactored Background.js code using jQuery eliminating all instances of innerHTML.
issue number 12
Steps to test:

  1. git fetch -A
  2. git checkout jr-backgroundjs-refactor
  3. Navigate to chrome://extensions and click the toggle to enter developer mode
  4. click Load Unpacked the extension should load in your search bar
  5. navigate to any website and copy the url
  6. click on the Cookie-Manager icon and click Set Cookie
  7. Fill out the small form by pasting the your URL into the Domain text box, give it a name, and a value
  8. copy your url again and open the Cookie Manager extension
  9. Paste your URL and click Display Cookies: you should see a table with the cookie you just saved for that URL
  10. Click delete cookie and confirm that the text box clears and the total cookies number is set to 0

PS. Thank you for letting me work on this project. The more I got to click around and see what it actually does I thought I could be really beneficial. if there is anything you would like changes in this PR I would be happy to fix it!

@vinitshahdeo vinitshahdeo self-requested a review October 11, 2019 21:50
@vinitshahdeo vinitshahdeo added enhancement New feature or request hacktoberfest labels Oct 11, 2019
@vinitshahdeo
Copy link
Owner

@JordanRosas Thanks for the PR.
You may look into a few good first issues which are up for grabs.

Link to the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants