add delete domain button and function #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gjohn34 Thanks for the PR. I'll review the code. You can take up some more issues - Thanks! |
vinitshahdeo
reviewed
Oct 6, 2019
index.html
Outdated
| @@ -57,6 +57,7 @@ <h2 class="title text-center text-capitalize">Cookie Manager</h2> | |||
| <input type="text" class="form-control" id="value" required="required"> | |||
| </div> | |||
| <button type = "button" class="btn btnBelow btn-danger" id="clear_cookies">Clear All Cookies</button> | |||
| <button type="button" class="btn btnBelow" id="delete_domain_cookies">Delete Domain Cookies</button> | |||
There was a problem hiding this comment.
Please, use any bootstrap button classes.
There was a problem hiding this comment.
Right. I've left it unstyled besides the font-declaration. What color were you after, red like the other one?
There was a problem hiding this comment.
As it's delete button, red will look good.
vinitshahdeo
approved these changes
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey sorry about the wait, i forgot that I factory reset my pc earlier and had to reset all my ssh keys and junk.
added un-styled button to buttonGroup
function to fetch cookies matching input then delete each cookie w/ matching domain.
repeat display cookies function to reset table.