Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update private property in package.json #116

Merged

Conversation

Adyasha8105
Copy link

@Adyasha8105 Adyasha8105 commented Mar 4, 2020

This PR solves the issue #109

@welcome
Copy link

welcome bot commented Mar 4, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@ghost
Copy link

ghost commented Mar 4, 2020

There were the following issues with this Pull Request

  • Commit: d4a1765
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Adyasha8105 👏

@vinitshahdeo vinitshahdeo merged commit f976670 into vinitshahdeo:feature/frontend Mar 5, 2020
@welcome
Copy link

welcome bot commented Mar 5, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

@muskankhedia
Copy link

@vinitshahdeo I am from the GSSoC web-team. I was just going through some of the Merged PRs in GSSoC, I came across this problem. Please do add the gssoc20 tag and easy, beginner, medium or hard tag before merging a PR as announced many times in the slack channel. Else many students may lose points because of this.

Please keep a note of this and also inform your mentors team for the smooth and successful conduct of the program.

@vinitshahdeo vinitshahdeo added gssoc20 Welcome to GirlScript Summer of Code 2020 easy Easy issue labels Mar 9, 2020
@vinitshahdeo
Copy link
Owner

@muskankhedia Noted! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants