dynamicbloom fix: don't offset address when it is already aligned

Summary: this causes overflow and asan failure Test Plan: make asan_check Reviewers: igor Reviewed By: igor CC: leveldb Differential Revision: https://reviews.facebook.net/D17301
vinniefalco · Mar 29, 2014 · 550cca7 · 550cca7
1 parent 43a593a
commit 550cca7
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/util/dynamic_bloom.cc b/util/dynamic_bloom.cc
@@ -39,7 +39,7 @@ DynamicBloom::DynamicBloom(uint32_t total_bits,
     sz += CACHE_LINE_SIZE - 1;
   }
   raw_ = new unsigned char[sz]();
-  if (kBlocked) {
+  if (kBlocked && (reinterpret_cast<uint64_t>(raw_) % CACHE_LINE_SIZE)) {
     data_ = raw_ + CACHE_LINE_SIZE -
       reinterpret_cast<uint64_t>(raw_) % CACHE_LINE_SIZE;
   } else {