Followup code refactor on plain table

Summary: Fixed most comments in https://reviews.facebook.net/D15429. Still have some remaining comments left. Test Plan: make all check Reviewers: sdong, haobo Reviewed By: haobo CC: leveldb Differential Revision: https://reviews.facebook.net/D15885
vinniefalco · Feb 13, 2014 · b2e7ee8 · b2e7ee8
1 parent 85c0545
commit b2e7ee8
Show file tree

Hide file tree

Showing 4 changed files with 139 additions and 131 deletions.
diff --git a/db/plain_table_db_test.cc b/db/plain_table_db_test.cc
@@ -190,12 +190,10 @@ class TestPlainTableReader : public PlainTableReader {
                        const TableProperties* table_properties,
                        unique_ptr<RandomAccessFile>&& file,
                        const Options& options, bool* expect_bloom_not_match)
-      : PlainTableReader(storage_options, icomparator, file_size,
-                         bloom_bits_per_key, hash_table_ratio, index_sparseness,
-                         table_properties),
+      : PlainTableReader(options, std::move(file), storage_options, icomparator,
+                         file_size, bloom_bits_per_key, hash_table_ratio,
+                         index_sparseness, table_properties),
         expect_bloom_not_match_(expect_bloom_not_match) {
-    file_ = std::move(file);
-    options_ = options;
     Status s = PopulateIndex();
     ASSERT_TRUE(s.ok());
   }