Skip to content

Commit

Permalink
Perform code review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Himanshu21git committed Jan 22, 2024
1 parent f830167 commit 68bf13d
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 25 deletions.
18 changes: 8 additions & 10 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,15 @@ A clear and concise description of what you expected to happen.
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**

- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**

- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

**Additional context**
Add any other context about the problem here.
Add any other context about the problem here.
14 changes: 7 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,28 +2,28 @@

## v0.10.1

* Fix a bug with `nil` decimals that happens on Ecto 3.11+.
* Fix a bug with `nil` decimals that happens on Ecto 3.11+.

## v0.10.0

* Update the `:xandra` requirement to `~> 0.18.0`.
* Update the `:xandra` requirement to `~> 0.18.0`.

## v0.9.1

* Fix issues with migrations generating invalid CQL statements.
* Fix issues with migrations generating invalid CQL statements.

## v0.9.0

* Add the `Exandra.Counter.t/0` type.
* Add the `Exandra.Counter.t/0` type.

## v0.8.1

* Fix issue with types in map column.
* Fix issue with types in map column.

## v0.8.0

* Add support for multiple keyspaces.
* Add support for multiple keyspaces.

## v0.6.5

* Update the `:xandra` requirement to `~> 0.17.0`.
* Update the `:xandra` requirement to `~> 0.17.0`.
8 changes: 3 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ To configure your Ecto repository to use this adapter, you can use the

```elixir
defmodule MyApp.Repo do
use Ecto.Repo,
otp_app: :my_app,
adapter: Exandra
use Ecto.Repo, otp_app: :my_app, adapter: Exandra
end
```

Expand Down Expand Up @@ -84,7 +82,7 @@ field :features, :map

you can pass the field as an Elixir map when setting it, and Exandra will convert it to a map
on the way from the database. Because Exandra uses JSON for this, you'll have to pay attention
to things such as atom keys (which can be used when writing but will be strings when reading)
to things such as atom keys (which can be used when writing, but will be strings when reading)
and such.

### User-Defined Types (UDTs)
Expand Down Expand Up @@ -157,7 +155,7 @@ defmodule AddUsers do
end
```

> ### Cassandra and Scylla Types {: .info}
> #### Cassandra and Scylla Types {: .info}
>
> When writing migrations, remember that you must use the **actual types** from Cassandra or
> Scylla, which you must pass in as an *atom*.
Expand Down
4 changes: 1 addition & 3 deletions lib/exandra.ex
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ defmodule Exandra do
`:adapter` option. For example, when defining the repo:
defmodule MyApp.Repo do
use Ecto.Repo,
otp_app: :my_app,
adapter: Exandra
use Ecto.Repo, otp_app: :my_app, adapter: Exandra
end
You can configure your database connection in `config/dev.exs`. Here's an example `dev configuration`:
Expand Down

0 comments on commit 68bf13d

Please sign in to comment.