feat: support options for insertions #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correctly build query from options by adding `Exandra.Connection.insert/7` which accepts options as the last parameter. `Exandra.insert` and `Exandra.insert_all` are overwritten so that they can call this function instead of the default.
|
@vinniefranco could you please take a look here? It would solve some issues (e.g. can't use Exandra for writing inserts with TTL, see #76) and make Exandra more in line with other Ecto adapters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correctly build query from options by adding
Exandra.Connection.insert/7which accepts options as the last parameter.Exandra.insertandExandra.insert_allare overwritten so that they can call this function instead of the default.Closes #76
Exandra.insertandExandra.insert_all(andunzip_inserts) have been taken from ecto_sql, which is licensed under the Apache 2.0 license.Should I somehow mark these functions as being licensed under Apache?