Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Clean up RCC handling #89

Closed
vintagepc opened this issue Sep 30, 2021 · 0 comments · Fixed by #102
Closed

[FEATURE] Clean up RCC handling #89

vintagepc opened this issue Sep 30, 2021 · 0 comments · Fixed by #102
Labels
enhancement New feature or request rework_pending something that's partially complete and waiting for other components to be ready

Comments

@vintagepc
Copy link
Owner

vintagepc commented Sep 30, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

Right now we pass raw pointers to the RCC objects in a nasty way that violates the innards of the object model.

Change this to do it right - use object_property_set_link() for example.

Also, use native clock types and leverage qemu's clock_ticks_to_ns instead of manually calculating it where peripheral behaviour is clock-driven.
@vintagepc vintagepc added the enhancement New feature or request label Sep 30, 2021
@vintagepc vintagepc added the rework_pending something that's partially complete and waiting for other components to be ready label Jan 25, 2022
vintagepc added a commit that referenced this issue Jan 29, 2022
@vintagepc
Major RCC refactor (#89) and DMA cleanup (#30)
c0b5af1
@vintagepc vintagepc mentioned this issue Jan 29, 2022
Merged
vintagepc added a commit that referenced this issue Jan 29, 2022
@vintagepc
Major RCC refactor (#89) and DMA cleanup (#30) (#102)
3d19b35 
* Major RCC refactor (#89) and DMA cleanup (#30)
* use QEMU_BUILD_BUG_MSG instead of static_assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request rework_pending something that's partially complete and waiting for other components to be ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major RCC refactor (#89) and DMA cleanup (#30) vintagepc/MINI404
1 participant
@vintagepc