discovery: preserve results from other resolve calls #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasr
approved these changes
Nov 5, 2024
simonasgal
approved these changes
Nov 5, 2024
GiedriusS
force-pushed
the
thanos_query_map_fix
branch
2 times, most recently
from
fa147d2 to
e14c47c
Compare
Properly preserve results from other resolve calls. There is an assumption that resolve() is always called with the same addresses but that is not true with gRPC and `--endpoint-group`. Without this fix, multiple resolves could happen at the same time but some of the callers will not be able to retrieve the results leading to random errors. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
thanos_query_map_fix
branch
from
e14c47c to
4ed126f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly preserve results from other resolve calls. There is an assumption that resolve() is always called with the same addresses but that is not true with gRPC and
--endpoint-group. Without this fix, multiple resolves could happen at the same time but some of the callers will not be able to retrieve the results leading to random errors.