add tests

tests/fixtures/multi_line_comment.hcl

@@ -0,0 +1,4 @@
+/*
+    test multi line comment
+*/
+foo = "bar"

tests/fixtures/multi_line_comment.json

@@ -0,0 +1,3 @@
+{
+    "foo": "bar"
+}

tests/fixtures/multi_line_comment_M.json

@@ -0,0 +1,4 @@
+{
+    "comment-L001": "/*\n    test multi line comment\n*/",
+    "foo": "bar"
+}

tests/fixtures/single_line_comment.hcl

@@ -0,0 +1,3 @@
+// test single line comment with slash
+# test single line comment with hashtag
+foo = "bar"

tests/fixtures/single_line_comment.json

@@ -0,0 +1,3 @@
+{
+    "foo": "bar"
+}

tests/fixtures/single_line_comment_L.json

@@ -0,0 +1,5 @@
+{
+    "comment-L001": "test single line comment with slash",
+    "comment-L002": "test single line comment with hashtag",
+    "foo": "bar"
+}

tests/fixtures/structure_comment.hcl

@@ -0,0 +1,7 @@
+foo {
+    // single line comment
+    /*
+        multi line comment
+    */
+    foo = "bar"
+}

tests/fixtures/structure_comment_A.json

@@ -0,0 +1,7 @@
+{
+    "foo": {
+        "comment-L002": "single line comment",
+        "comment-L003": "/*\n        multi line comment\n    */",
+        "foo": "bar"
+    }
+}

tests/fixtures/structure_comment_L.json

@@ -0,0 +1,6 @@
+{
+    "foo": {
+        "comment-L002": "single line comment",
+        "foo": "bar"
+    }
+}

tests/fixtures/structure_comment_M.json

@@ -0,0 +1,6 @@
+{
+    "foo": {
+        "comment-L003": "/*\n        multi line comment\n    */",
+        "foo": "bar"
+    }
+}

tests/test_decoder.py

@@ -60,3 +60,28 @@ def test_decoder(hcl_fname, json_fname, struct):
 
     if struct is not None:
         assert hcl_json == struct
+
+
+COMMENTED_FIXTURES = [
+    ('single_line_comment.hcl', 'single_line_comment_L.json', "single_line_comment.json", 'single_line_comment_L.json'),
+    ('multi_line_comment.hcl', 'multi_line_comment.json', 'multi_line_comment_M.json', 'multi_line_comment_M.json'),
+    ('structure_comment.hcl', 'structure_comment_L.json', 'structure_comment_M.json', 'structure_comment_A.json'),
+    ('array_comment.hcl', 'array_comment.json', 'array_comment.json', 'array_comment.json')
+]
+
+@pytest.mark.parametrize("export_comments", ['LINE', 'MULTILINE', 'ALL'])
+@pytest.mark.parametrize("hcl_fname,sline_fname,mline_fname,aline_fname", COMMENTED_FIXTURES)
+def test_decoder_export_comments(hcl_fname, sline_fname, mline_fname, aline_fname, export_comments):
+    with open(join(FIXTURE_DIR, hcl_fname), 'r') as fp:
+        hcl_json = hcl.load(fp, export_comments)
+
+    json_fname = {
+        "LINE": sline_fname,
+        "MULTILINE": mline_fname,
+        "ALL": aline_fname
+    }
+
+    with open(join(FIXTURE_DIR, json_fname[export_comments]), 'r') as fp:
+            good_json = json.load(fp)
+
+    assert hcl_json == good_json

tests/test_lexer.py

@@ -391,21 +391,9 @@ def test_tokens(token, input_string):
         assert token == lex_tok.type
         assert lexer.token() is None
 
-@pytest.mark.parametrize("token,input_string", TOKEN_FIXTURES)
-def test_tokens_with_export_comments_wrong_parameter(token, input_string):
-
-    print(input_string)
-
-    lexer = hcl.lexer.Lexer(export_comments="WRONG")
-    lexer.input(input_string)
-
-    lex_tok = lexer.token()
-
-    if lex_tok is None:
-        assert token is None
-    else:
-        assert token == lex_tok.type
-        assert lexer.token() is None
+def test_export_comments_wrong_parameter():
+    with pytest.raises(ValueError):
+        lexer = hcl.lexer.Lexer(export_comments="WRONG")
 
 ONE_LINE_COMMENT_FIXTURES = [
     ("COMMENT", "//"),

tests/test_load_dump.py

@@ -70,30 +70,31 @@
     ),
 ]
 
+@pytest.mark.parametrize("export_comments", [None, 'LINE', 'MULTILINE', 'ALL'])
 @pytest.mark.parametrize("hcl_fname,invalid", PARSE_FIXTURES)
-def test_parser_bytes(hcl_fname, invalid):
-
+def test_parser_bytes(hcl_fname, invalid, export_comments):
     with open(join(PARSE_FIXTURE_DIR, hcl_fname), 'rb') as fp:
 
         input = fp.read()
         print(input)
 
         if not invalid:
-            hcl.loads(input)
+            hcl.loads(input, export_comments)
         else:
             with pytest.raises(ValueError):
-                hcl.loads(input)
+                hcl.loads(input, export_comments)
 
+@pytest.mark.parametrize("export_comments", [None, 'LINE', 'MULTILINE', 'ALL'])
 @pytest.mark.parametrize("hcl_fname,invalid", PARSE_FIXTURES)
-def test_parser_str(hcl_fname, invalid):
+def test_parser_str(hcl_fname, invalid, export_comments):
 
     with open(join(PARSE_FIXTURE_DIR, hcl_fname), 'r') as fp:
 
         input = fp.read()
         print(input)
 
         if not invalid:
-            hcl.loads(input)
+            hcl.loads(input, export_comments)
         else:
             with pytest.raises(ValueError):
-                hcl.loads(input)
+                hcl.loads(input, export_comments)

tests/test_parser.py

@@ -70,30 +70,32 @@
     ),
 ]
 
+@pytest.mark.parametrize("export_comments", [None, 'LINE', 'MULTILINE', 'ALL'])
 @pytest.mark.parametrize("hcl_fname,invalid", PARSE_FIXTURES)
-def test_parser_bytes(hcl_fname, invalid):
+def test_parser_bytes(hcl_fname, invalid, export_comments):
 
     with open(join(PARSE_FIXTURE_DIR, hcl_fname), 'rb') as fp:
 
         input = fp.read()
         print(input)
 
         if not invalid:
-            hcl.loads(input)
+            hcl.loads(input, export_comments)
         else:
             with pytest.raises(ValueError):
-                hcl.loads(input)
+                hcl.loads(input, export_comments)
 
+@pytest.mark.parametrize("export_comments", [None, 'LINE', 'MULTILINE', 'ALL'])
 @pytest.mark.parametrize("hcl_fname,invalid", PARSE_FIXTURES)
-def test_parser_str(hcl_fname, invalid):
+def test_parser_str(hcl_fname, invalid, export_comments):
 
     with open(join(PARSE_FIXTURE_DIR, hcl_fname), 'r') as fp:
 
         input = fp.read()
         print(input)
 
         if not invalid:
-            hcl.loads(input)
+            hcl.loads(input, export_comments)
         else:
             with pytest.raises(ValueError):
-                hcl.loads(input)
+                hcl.loads(input, export_comments)