[v8] Align type names with base map libraries #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | RasterDemSource; | ||
| // Sources | ||
| AnySourceData as SourceSpecification, | ||
| CanvasSourceRaw as CanvasSourceSpecification, |
There was a problem hiding this comment.
Can you help me understand why we're aliasing some of these specifications?
There was a problem hiding this comment.
This will match type names from @types/mapbox-gl (unofficial types) with the latest mapbox-gl official type names.
chrisgervang
approved these changes
Jan 25, 2025
Pessimistress
force-pushed
the
x/types-align
branch
from
bf98a3f to
0cc4544
Compare
|
Mapbox v3 and Maplibre v5 type naming conventions are mostly the same, aside from actual API difference, and some niche exceptions. |
Pessimistress
added a commit
that referenced
this pull request
Jan 28, 2025
Pessimistress
added a commit
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See upgrade-guide.md
Docs will be updated in a separate PR.