Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IFLA_PARENT_DEV_NAME / IFLA_PARENT_DEV_BUS_NAME to links #1051

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add IFLA_PARENT_DEV_NAME / IFLA_PARENT_DEV_BUS_NAME to links #1051

wants to merge 1 commit into from

Conversation

akerouanton
Copy link

These attributes are supported since kernel v5.14 (see 1). Here's what iproute2 shows:

$ ip -d link show eth0
4: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 65535 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    ... parentbus virtio parentdev virtio0

@akerouanton
Copy link
Author

akerouanton commented Jan 20, 2025 •
edited
Loading

It seems the failing test is a flake. I was able to reproduce it once out of a few runs on main.

--- FAIL: TestRuleListFiltered (1.01s)
    --- FAIL: TestRuleListFiltered/IPv6 (1.01s)
        --- FAIL: TestRuleListFiltered/IPv6/returns_one_rule_filtered_by_Dst (1.00s)

@akerouanton
Add IFLA_PARENT_DEV_NAME / IFLA_PARENT_DEV_BUS_NAME to links
bc9fc1d 
These attributes are supported since kernel v5.14 (see [1]). Here's
what iproute2 shows:

```
$ ip -d link show eth0
4: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 65535 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
    ... parentbus virtio parentdev virtio0
```

[1]: torvalds/linux@00e77ed

Signed-off-by: Albin Kerouanton <[email protected]>
thaJeztah
thaJeztah approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aboch
Copy link
Collaborator

aboch commented Jan 21, 2025

Thanks @akerouanton
Would it be possible to add a new or extend and existing UT function to cover these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akerouanton @aboch @thaJeztah