-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/smaller improvements #1854
Fix/smaller improvements #1854
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, thanks @noahonyejese!
There is one potentially bigger refactor (createSupportMailtoLink
) and some clarification questions in menu item actions that would be good to take a second look at 🙏
@bprusinowski sorry I was having a bit of trouble with selecting the lines in one file that belong to this issue 😅, Since solange wanted the issues in separate PR's but some are closely related, some lines slipped in that wasn't meant for this PR. |
@bprusinowski just realized that it doesn't make to much sense to optimize the createMailtoLink since this is something that we want to no longer use in the future. In the future the goal is to use a better way of creating all this emails. I will be exploring our options soon. |
This PR:
Details
@bprusinowski not sure how to better position the nested
Menu
let me know about potential improvementsHow to Test
Feedback >
button ✅Feedback >
button see how there is Report Bug and