Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/smaller improvements #1854

Merged
merged 11 commits into from
Nov 13, 2024
Merged

Fix/smaller improvements #1854

merged 11 commits into from
Nov 13, 2024

Conversation

noahonyejese
Copy link
Contributor

@noahonyejese noahonyejese commented Nov 13, 2024

This PR:

Details
@bprusinowski not sure how to better position the nested Menu let me know about potential improvements


How to Test

  1. This can only be tested once deployed
  2. Login
  3. Open the Dropdown See the new Feedback > button ✅
  4. Click the Feedback > button see how there is Report Bug and

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 10:59am

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, thanks @noahonyejese!

There is one potentially bigger refactor (createSupportMailtoLink) and some clarification questions in menu item actions that would be good to take a second look at 🙏

app/login/components/login-menu.tsx Outdated Show resolved Hide resolved
app/login/components/login-menu.tsx Outdated Show resolved Hide resolved
app/login/components/login-menu.tsx Show resolved Hide resolved
app/login/components/login-menu.tsx Show resolved Hide resolved
app/components/menu-action-item.tsx Outdated Show resolved Hide resolved
app/components/menu-action-item.tsx Outdated Show resolved Hide resolved
app/components/publish-actions.tsx Outdated Show resolved Hide resolved
app/login/components/profile-tables.tsx Outdated Show resolved Hide resolved
@noahonyejese
Copy link
Contributor Author

@bprusinowski sorry I was having a bit of trouble with selecting the lines in one file that belong to this issue 😅, Since solange wanted the issues in separate PR's but some are closely related, some lines slipped in that wasn't meant for this PR.

@noahonyejese
Copy link
Contributor Author

@bprusinowski just realized that it doesn't make to much sense to optimize the createMailtoLink since this is something that we want to no longer use in the future. In the future the goal is to use a better way of creating all this emails. I will be exploring our options soon.

@noahonyejese noahonyejese merged commit c418366 into main Nov 13, 2024
5 of 6 checks passed
@noahonyejese noahonyejese deleted the fix/smaller-improvements branch November 13, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✓ Development: Request New Funtionality Button ✓Automated Bug Reporting for End Users
2 participants