Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined and null values get replaced w/ "-" #1912

Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix: undefined and null values get replaced w/ "-" #1912

merged 4 commits into from
Nov 25, 2024

Conversation

noahonyejese
Copy link
Contributor

@noahonyejese noahonyejese commented Nov 25, 2024 •
edited
Loading

This PR:

How to test

  1. Go to this link
  2. Create a visualization w/ this Data => LFI: Themen nach Baumart (5 Klassen)
  3. Publish Visualization
  4. Click on Dataset in the bottom left corner
  5. Click on Download data
  6. Click CSV
  7. Scroll through the file see how there are a bunch of zeros ❌

repeat steps 1 - 6 with this link

  1. See how some of the zeros, were actually undefined values now they are replaced with "-" dashes ✅

CC: @sosiology

@noahonyejese noahonyejese self-assigned this Nov 25, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 3:50pm

bprusinowski
bprusinowski approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @noahonyejese 🙇‍♂️

app/components/data-download.tsx Show resolved Hide resolved
@noahonyejese noahonyejese merged commit f4d05db into main Nov 25, 2024
3 of 4 checks passed
@noahonyejese noahonyejese deleted the fix/zero-for-undefined-values branch November 25, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprusinowski bprusinowski bprusinowski approved these changes

Assignees

@noahonyejese noahonyejese

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PROD : Visualize dispay Value = "0" instead of ‘no value’.
2 participants
@noahonyejese @bprusinowski