Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable multiline Input #2035

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix: Disable multiline Input #2035

merged 2 commits into from
Jan 29, 2025

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jan 29, 2025

Closes #2010

This PR removes the multiline property from Input so that it does not extend when hitting Enter. This change was introduced while working on the dashboard text blocks, but as we switched to using a third-party library for Markdown inputs, this should have been removed.

How to test

  1. Go to this link.
  2. Enter some text in the search bar above the table and hit Enter.
  3. ✅ See that the input field doesn't extend.

How to reproduce

See the instructions in #2010.


  • Add a CHANGELOG entry

Sorry, something went wrong.

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 10:21am

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bprusinowski
Copy link
Collaborator Author

@noahonyejese @squiles as the fix was trivial, as it essentially reverts one change I did when working on dashboard text blocks and we want to deploy most recent version to INT, I will merge this PR 👍

@bprusinowski bprusinowski merged commit c2a5f7b into main Jan 29, 2025
12 of 13 checks passed
@bprusinowski bprusinowski deleted the fix/multiline-input branch January 29, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✓✓ Search bar height increases when hitting enter
1 participant