Update index.js to allow for any language URL to be used #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update index.js to allow for v2 of the URL code (fixes matheuss#10 in an even better way than how v1 did it to begin with).
rawr51919
changed the title
This was referenced Mar 6, 2019
Updates index.js to allow for the URL variable to be passed in from the main API function
vitalets
requested changes
Mar 13, 2019
|
Not sure how I'll be able to add the changes you requested, though. Might need to look over some more of this part of JS. |
|
Never mind! |
|
@vitalets Go ahead. Hopefully then it should work with the API PR and fix the issues I had documented here. Close this when you've finished. |
vitalets
pushed a commit
that referenced
this pull request
Mar 18, 2019
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update index.js to allow for v2 of the URL code (works in an even better way than how PR #1 did it to begin with, fixing the issues documented there. It's now tied to PR vitalets/google-translate-api#7).